Javascript problem PLEASE HELP

[andrew]

I am really stuck and would really apreciate some help. I've been given the task of making a flat webpage for a client at work, the problem i'm having is they want some ads on the site and have supplied ad tags in Javascript. Unfortunatley i've never touched javascript. I'm guessing the random number generator goes into the head of the code but where do i put the other parts of the code? I've made a <div> that will hold the banner, will the remaining code sit in there?

The code is below....

*** Code ***
RANDOM NUMBER GENERATOR - Use only once per page between the head commands

<script language="Javascript">
<!--
var axel = Math.random() + "";
var ord = axel * 1000000000000000000;
//-->
</script>

************************************************** *
a.pop.tmus/achemy-skyscraper 160x600
************************************************** *
<SCRIPT LANGUAGE="JavaScript">
document.write('<SCR'+'IPT LANGUAGE="JavaScript1.1" SRC="a_rather_long_url;tile=1;dcopt=ist;sz=160x600;ord= ' + ord + '?" ><\/SCRIPT>');
</SCRIPT>
<SCRIPT>
if ((!document.images && navigator.userAgent.indexOf("Mozilla/2.") >= 0) || navigator.userAgent.indexOf("WebTV")>= 0) {
document.write('<A HREF="a_rather_long_url;tile=1;sz=160x600;ord=' + ord + '?" TARGET="_blank">');
document.write('<IMG SRC="a_rather_long_url;tile=1;sz=160x600;ord=' + ord + '?" WIDTH="160" HEIGHT="600" BORDER="0" ALT=""></A>');
}
</SCRIPT>
<NOSCRIPT>
<A HREF="a_rather_long_url;tile=1;sz=160x600;ord=123456789? " TARGET="_blank">
<IMG SRC="a_rather_long_url;tile=1;sz=160x600;ord=123456789? " WIDTH="160" HEIGHT="600" BORDER="0" ALT=""></A>
</NOSCRIPT>

[Dom]

The other part of the code appears to be what prints out the banner/ad itself, so you'd be right.
____________________
Photos and that

[bob-a-job]

[andrew]

The thing is, when i insert the code into the banner <div> it isn't a clickable link when it should be. If i place all the code between the <script> tags into the head and the <noscript> bit of the code into the div, and remove the <noscript> tags then it is clickable. Surely the company who gave me the code wouldn't be giving out code that would need to be edited like this.

Any ideas?

[Dom]

Firstly you shouldn't need a containing div, so you might as well ditch that to be sure it's not the problem.

Secondly if your removing the noscript tag 'fixes' it then is there a chance it's an odd behaviour from your own browser? (Have you tested in several?)

As you say, auto-generated code directly from the ad company should be perfect, so it's certainly strange. Though in truth that ad code does look a bit of a mess, quite why they need to go generating random numbers I've no idea.
____________________
Photos and that

[andrew]

Well it's going into a <div> so that i can posistion the banner. Someone else told me the code was a mess but wouldn't tell me why so i'm a bit stuck to be honest.

Could the number generator change the banner depending on what nubmer is generated when the javascript is loaded?

[Dom]

That appears to be what it's doing. The variable's called 'ord' and they've got it peppered around all over the place.

Tbh you may be best of asking this at a more techy forum. Although I implement a fair bit of JS I don't write much and tbh I'm not sure what the problem is here.

As a rule noscript content should only appear where scripting is disabled, so for it to effect what's going on when scripting's enabled is very weird.

Try Sitepoint.com/forums.
____________________
Photos and that

[TheShaggyDA]

The random number is being used to generate a unique url, so that it will always fetch the banner rather than attempt to use a cached copy.

In the NOSCRIPT area, it's just hardcoded to "123456789?", so they won't get as many hits from that.
____________________
Current: CB500 Previous: CB100N, CB250RS, XJ900F, GT550, GPZ750R/1000RX, AJS M16, R100RT, Enfield Bullet

[i:6e3bfc7581]But still I fear and still I dare not laugh at the madman...[/i:6e3bfc7581]

[Kickstart]

[andrew]

[Dom]

To be 100% sure, you have only submit the URL with 'a rather long url' for the sake of BCF right?

Can you just post the full URLs so we can test it?
____________________
Photos and that

[andrew]

[Kickstart]

Hi

Can you PM them to me as well.

All the best

Keith
____________________
Traxpics, track day and racing photographs - Bimota Forum - Bike performance / thrust graphs for choosing gearing

[andrew]

Done.

[Kickstart]

Hi

The if statement where it decides whether to put out the link does not equate to true on my machine, the displays are not executed.

All the best

Keith
____________________
Traxpics, track day and racing photographs - Bimota Forum - Bike performance / thrust graphs for choosing gearing

[andrew]

So what that code is doing is not displaying the ad codes because the user agent isn't mozilla??

[Kickstart]

Hi

For me "navigator.userAgent.indexOf("Mozilla/2.")" returns -1 (navigator.useragent is "Opera/9.01 (Windows NT 5.1; U; en)"), so basically I think what it is checking for is a bit screwy.

All the best

Keith
____________________
Traxpics, track day and racing photographs - Bimota Forum - Bike performance / thrust graphs for choosing gearing